Add missing SourceLoc to newly-emitted instructions#2335
Merged
abrown merged 1 commit intobytecodealliance:mainfrom Oct 28, 2020
Merged
Add missing SourceLoc to newly-emitted instructions#2335abrown merged 1 commit intobytecodealliance:mainfrom
SourceLoc to newly-emitted instructions#2335abrown merged 1 commit intobytecodealliance:mainfrom
Conversation
Member
Author
|
cc: @cfallin, @akirilov-arm, @jlb6740--let's see if this fix works! |
The changes in bytecodealliance#2278 added `SourceLoc`s to several x64 `Inst` variants; between when that PR was last run in CI and when it was merged, new instructions were added that require this new parameter. This change adds the parameter in order to fix CI.
jlb6740
approved these changes
Oct 28, 2020
Member
Author
|
This CI run (started before the PR was closed and re-opened, which apparently restarts CI--good to know!) is now complete so I am going to merge. |
This was referenced Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in #2278 added
SourceLocs to several x64Instvariants; between when that PR was last run in CI and when it was merged, new instructions were added that require this new parameter. This change adds the parameter in order to fix CI.