lightbeam: fix comment typo for BrIf#1224
Closed
tiborvass wants to merge 1 commit intobytecodealliance:mainfrom
Closed
lightbeam: fix comment typo for BrIf#1224tiborvass wants to merge 1 commit intobytecodealliance:mainfrom
tiborvass wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Signed-off-by: Tibor Vass <teabee89@gmail.com>
arkpar
pushed a commit
to paritytech/wasmtime
that referenced
this pull request
Mar 4, 2020
arkpar
pushed a commit
to paritytech/wasmtime
that referenced
this pull request
Mar 4, 2020
…solved (bytecodealliance#1224)" This reverts commit 589fa95.
Subscribe to Label ActionThis issue or pull request has been labeled: "l", "i", "g", "h", "t", "b", "e", "a", "m" To subscribe or unsubscribe from this label, edit the |
2 similar comments
Subscribe to Label ActionThis issue or pull request has been labeled: "l", "i", "g", "h", "t", "b", "e", "a", "m" To subscribe or unsubscribe from this label, edit the |
Subscribe to Label ActionThis issue or pull request has been labeled: "l", "i", "g", "h", "t", "b", "e", "a", "m" To subscribe or unsubscribe from this label, edit the |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibor Vass teabee89@gmail.com
I've already opened this PR to the now archived lightbeam repo: CraneStation/lightbeam#20
Which prompts me to ask: why is an older version of lightbeam in wasmtime? Was it just an oversight?