Skip to content
This repository was archived by the owner on Mar 24, 2022. It is now read-only.

lucetc: report all unresolved bindings, not just the first one#438

Closed
jedisct1 wants to merge 2 commits into
mainfrom
fdenis/unknown-bindings
Closed

lucetc: report all unresolved bindings, not just the first one#438
jedisct1 wants to merge 2 commits into
mainfrom
fdenis/unknown-bindings

Conversation

@jedisct1
Copy link
Copy Markdown
Contributor

@jedisct1 jedisct1 commented Mar 2, 2020

No description provided.

@fst-crenshaw
Copy link
Copy Markdown
Contributor

Thanks for this quick work to improve the error output that lucet provides! It will help users to know the full list of unresolved bindings.

One of the things that bit me a little bit over in #374 was the lack of tests on error output. I ended up squashing too much error output. 😿

With that in mind, I wonder if you might have plans to add a test for this work?

@jedisct1
Copy link
Copy Markdown
Contributor Author

jedisct1 commented Mar 2, 2020

Is anyhow guaranteed to always print errors the same way, byte for byte?

Comment thread lucet-module/src/error.rs Outdated
@pchickey
Copy link
Copy Markdown
Contributor

pchickey commented Mar 2, 2020

@jedisct1 for testing I'd reuse the existing import_many.wat test and match on the lucetc::Error, rather than coerce it to an anyhow::Error.

@pchickey pchickey closed this Jun 26, 2020
@pchickey
Copy link
Copy Markdown
Contributor

This PR was closed as a byproduct of deleting the branch named master. If this is still an active PR, re-open as a new PR against main.

@acfoltzer acfoltzer reopened this Jun 26, 2020
@acfoltzer acfoltzer changed the base branch from master to main June 26, 2020 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants