Skip to content

chore(deps): update js-component-bindgen#337

Open
vados-cosmonic wants to merge 4 commits into
bytecodealliance:mainfrom
vados-cosmonic:chore(deps)=update-js-component-bindgen
Open

chore(deps): update js-component-bindgen#337
vados-cosmonic wants to merge 4 commits into
bytecodealliance:mainfrom
vados-cosmonic:chore(deps)=update-js-component-bindgen

Conversation

@vados-cosmonic
Copy link
Copy Markdown
Contributor

No description provided.

@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-js-component-bindgen branch from d1f7b29 to ab506f6 Compare May 15, 2026 12:20
This updates wirm to 5.0.0 to re-enable the custom section deleting functionality
@tschneidereit
Copy link
Copy Markdown
Member

@vados-cosmonic there seems to be a lot more going on here than just an update of one dependency. Can you update the description to include which changes you made, so I know what to look for?

@vados-cosmonic
Copy link
Copy Markdown
Contributor Author

Hey @tschneidereit so the update of one dep triggered the other updates. Because a newer version of js-component-bindgen uses newer versions of ecosystem crates (and we can't use arbitrarily different versions) it prompts an update of the crates. Another thing that componentize-js uses is wirm, which also has a copy of the ecosystem crates -- so you can see where the updates come from.

That said, this isn't working yet -- there seems to be some generation problem I'm looking into, so it's not quite ready for review just yet -- but the intention here is definitely to update the single dep, it's just more involved than one would otherwise think. Two people from the community have already tried (and had a hard time).

@vados-cosmonic
Copy link
Copy Markdown
Contributor Author

Hey @tschneidereit OK this is ready for review now -- tests are green!

Given the current code, the only change that will be made is js-component-bindgen which is @ 1.19.0-rc.7 will change to 1.19.0 as soon as the release goes out, no more changes to the code in componentize-js should be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants