This repository was archived by the owner on Oct 31, 2024. It is now read-only.
Fix parsing for boolean expressions starting with negation#66
Merged
iconara merged 1 commit intoburtcorp:masterfrom Dec 4, 2021
Merged
Fix parsing for boolean expressions starting with negation#66iconara merged 1 commit intoburtcorp:masterfrom
iconara merged 1 commit intoburtcorp:masterfrom
Conversation
Collaborator
|
Awesome, thank you for the contribution. I will try to merge this and deploy a new version as soon as I can, but apologies if it takes a few days. |
iconara
approved these changes
Nov 19, 2021
Collaborator
iconara
left a comment
There was a problem hiding this comment.
Great that you included the two tests in addition to the PR on the compliance test suite.
Author
|
Thanks for approval. Do you have expected date for a new version to be deployed? |
Collaborator
|
v0.5.1 has been released and should show up in Maven central soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed antlr grammar to correctly resolve boolean expressions starting with negation.
Before fix:
Expression
!True && False:truewhich is wrong.Negate(And(Property("True"), Property("False")))After fix:
Expression
!True && False:falseas expected.And(Negate(Property("True")), Property("False"))Also created PR to update compliance tests.
Issue link: #65