This repository was archived by the owner on Oct 31, 2024. It is now read-only.
Reduce StringEscapeHelper escape and unescape allocations#46
Merged
iconara merged 1 commit intoburtcorp:masterfrom Jun 7, 2019
gatling:string-escape-helper-optim
Merged
Reduce StringEscapeHelper escape and unescape allocations#46iconara merged 1 commit intoburtcorp:masterfrom gatling:string-escape-helper-optim
iconara merged 1 commit intoburtcorp:masterfrom
gatling:string-escape-helper-optim
Conversation
Motivation: * StringEscapeHelper allocates StringBuilder of default size (16) so there's a good chance it will either be too large, or too small and reallocate underlying char array. * escaped always allocate StringBuilder, even when there's nothing to escape in the input String. Modifications: * Set StringBuilder initial capacity * lazy allocate escape's StringBuilder Result: Less allocations.
Contributor
Author
|
ping @iconara |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Modifications:
Result:
Less allocations.