refactor: use custom registry instead of defaults, fix filteredTargets mutations#916
Merged
burningalchemist merged 2 commits intomasterfrom Mar 2, 2026
Merged
refactor: use custom registry instead of defaults, fix filteredTargets mutations#916burningalchemist merged 2 commits intomasterfrom
burningalchemist merged 2 commits intomasterfrom
Conversation
5e77bb3 to
587d2ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how Prometheus registries are handled in the SQL exporter application. The main change is to make the registry used for metrics collection configurable, rather than relying on a global default. This improves flexibility and testability by allowing custom registries to be injected where needed.
Registry handling improvements:
Exporterinterface and its implementation inexporter.goto use a custom Prometheus registry instead of the default global registry, including changes to the constructor and context-handling methods. [1] [2] [3] [4]registerScrapeErrorMetricfunction to accept a registry parameter and register the scrape error metric with the provided registry instead of the global one.Application and HTTP handler updates:
main.goto pass in the registry explicitly, and updated HTTP handler setup to use the custom registry for metric instrumentation. [1] [2]ExporterHandlerForfunction inpromhttp.goto accept a registry parameter and use it when gathering metrics, improving handler flexibility. [1] [2]