fix: export scrape_errors_total for related job filters#915
Merged
burningalchemist merged 1 commit intomasterfrom Mar 2, 2026
Merged
fix: export scrape_errors_total for related job filters#915burningalchemist merged 1 commit intomasterfrom
burningalchemist merged 1 commit intomasterfrom
Conversation
8cade38 to
ec1be8b
Compare
chore: string formatting fix: only include scrape_errors_total for related job filters revert: custom registry (in a separate pr)
ec1be8b to
0e666bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #903
This pull request introduces improved job filter handling and error reporting in the SQL exporter, as well as several code quality enhancements. The main changes include making job filter validation stricter, filtering metrics based on job filters, and updating logging and utility functions for clarity and robustness.
Job filter handling and error reporting:
SetJobFiltersmethod now validates job names, returns errors for invalid filters, and is updated to return an error instead of silently failing. The HTTP handler responds with a 400 error if invalid filters are provided. [1] [2]Metrics filtering:
FilterScrapeErrorsTotalmethod to theExporterinterface and implementation, which filters thescrape_errors_totalmetric family to only include metrics for jobs specified in the job filters. This is now applied in the HTTP handler. [1] [2] [3]Logging and code quality improvements:
parseContextLognow handles invalid items more gracefully and usesstrings.SplitSeq;TrimMissingCtxsimplified to usestrings.TrimPrefix. [1] [2]General refactoring: