Bump urllib3 to 2.7.0 (CVE-2026-44432, CVE-2026-44431)#111
Open
niceking wants to merge 1 commit into
Open
Conversation
Resolves Dependabot alert #13. urllib3 2.6.x has a decompression-bomb safeguard bypass in its streaming API: 1. Brotli-decoded HTTPResponse.read(amt=N) calls after the first one 2. HTTPResponse.drain_conn() called after partial read Neither vulnerable path is reachable from this collector today (api.py uses requests.post with no streaming, no Brotli, and no drain_conn against a trusted Buildkite endpoint), but bumping the transitive pin removes the alert and protects against future drift if streaming/Brotli usage is ever introduced. Note: urllib3 2.7.0 requires Python >= 3.10. The lockfile keeps urllib3 2.6.3 on Python 3.9 since upstream did not backport the fix. Python 3.9 users remain technically exposed but are unaffected in practice because this collector does not exercise the vulnerable code paths. Amp-Thread-ID: https://ampcode.com/threads/T-019e29a4-7a81-749e-9ab0-1ee2362dd132 Co-authored-by: Amp <amp@ampcode.com>
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the transitive
urllib3dependency to 2.7.0 to address two Dependabot alerts:Authorization,Cookie,Proxy-Authorization) forwarded across origins in proxied low-level redirects.Linear: TE-5845
Vulnerabilities
CVE-2026-44432 — decompression-bomb bypass (alert #13)
urllib3versions>= 2.6.0, < 2.7.0bypass decompression-bomb safeguards in two cases:HTTPResponse.read(amt=N)/stream(amt=N)call when the response is decoded with the officialbrotlilibrary.HTTPResponse.drain_conn()after a partial read (any compression algorithm).A small amount of highly-compressed data can be fully decoded in one operation → high CPU and memory pressure on the client (CWE-409 — data amplification).
CVE-2026-44431 — cross-origin header leak (alert #14)
urllib3versions>= 1.23, < 2.7.0strip sensitive headers on cross-origin redirects in the high-level APIs (urllib3.request(),PoolManager.request(),ProxyManager.request()), but do not strip them when the low-level flowProxyManager.connection_from_url().urlopen(..., assert_same_host=False)is used.Authorization,Cookie, andProxy-Authorizationcan leak across origins.Impact assessment for this project
The collector posts JSON payloads to the Buildkite Test Engine via
requests.post(...)incollector/api.py:analytics-api.buildkite.comby default, otherwise operator-configured).stream=True,iter_content,HTTPResponse.read(amt=...),drain_conn()are not used) → CVE-2026-44432 not reachable.brotli/brotlicffidependency → CVE-2026-44432 not reachable.ProxyManager, no low-levelconnection_from_url().urlopen(..., assert_same_host=False), no manual redirect handling → CVE-2026-44431 not reachable.raise_for_status().Neither vulnerability is exploitable in practice today. This bump is preventative — it clears the alerts and protects against future drift if streaming, Brotli, or low-level proxy usage is ever introduced.
Notes
urllib32.7.0 requires Python ≥ 3.10. Because this project still supports Python 3.9, the lockfile pinsurllib3 2.6.3for Python 3.9 and2.7.0for Python ≥ 3.10 (uv resolution markers). Upstream urllib3 did not backport either fix to the 2.6.x line, so Python 3.9 users remain technically exposed — but unaffected in practice because the collector does not exercise the vulnerable paths (see above).Verification