Fixes 3.0 install not actually installing anything#312
Closed
gulliverhan wants to merge 3 commits intobuildermethods:mainfrom
Closed
Fixes 3.0 install not actually installing anything#312gulliverhan wants to merge 3 commits intobuildermethods:mainfrom
gulliverhan wants to merge 3 commits intobuildermethods:mainfrom
Conversation
fixed default config.yml
Contributor
|
I haven't been able to replicate this issue. I'll monitor for other reports of similar issues. |
|
I had the same issue. This fix is correct. |
|
I had the same issue |
|
Same issue, haven't tried suggested fix yet though seems straightforward. Tested around an hour before this comment on a fresh, minimal, up to date ubuntu server LTS (Nobel) image. |
|
Also had to apply this fix on Windows 11 |
|
Having the same issue, I applied this fix locally and now I can install the profiles without problems. |
|
I had the same issue with WSL2 terminal in Ubuntu 24.... The fix worked for me, but commands were still failing... The fix was changing all increments to be from ((++)) -> ((++)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
without this you get this issue where nothing actually happens on install
~/Repos/site$ ~/agent-os/scripts/project-install.sh
=== Agent OS Project Installation ===
The issue was a bash quirk:
((chain_depth++)) - post-increment returns the OLD value (0), which bash treats as "false" → exit code 1
((++chain_depth)) - pre-increment returns the NEW value (1), which bash treats as "true" → exit code 0
With set -e enabled, the script was dying on that line.
Configuration:
Linked item
Checklist
Documented steps to test
Notes for reviewers
thanks for all your great work