Skip to content

Use canonical_id in rctx.download and use the latest github release version #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perezd merged 1 commit into from
May 29, 2024
Merged

Use canonical_id in rctx.download and use the latest github release version #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions buf/internal/toolchain.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,12 @@ def _buf_download_releases_impl(ctx):
ctx.report_progress("Finding latest buf version")

# Get the latest version from github. Refer: https://docs.github.com/en/rest/reference/releases
#
# TODO: Change this to use https://api.github.com/repos/bufbuild/buf/releases/latest once we hit v1.
ctx.download(
url = "https://api.github.com/repos/bufbuild/buf/releases?per_page=1",
output = "versions.json",
url = "https://api.github.com/repos/bufbuild/buf/releases/latest",
output = "version.json",
)
versions_data = ctx.read("versions.json")
versions = json.decode(versions_data)
version = versions[0]["name"]
version_data = ctx.read("version.json")
version = json.decode(version_data)["name"]

os, cpu = _detect_host_platform(ctx)
if os not in ["linux", "darwin", "windows"] or cpu not in ["arm64", "amd64"]:
Expand All @@ -123,11 +120,11 @@ def _buf_download_releases_impl(ctx):
cpu = "x86_64"

ctx.report_progress("Downloading buf release hash")
url = "{}/{}/sha256.txt".format(repository_url, version)
sha256 = ctx.download(
url = [
"{}/{}/sha256.txt".format(repository_url, version),
],
url = url,
sha256 = sha256,
canonical_id = url,
output = "sha256.txt",
).sha256
ctx.file("WORKSPACE", "workspace(name = \"{name}\")".format(name = ctx.name))
Expand All @@ -147,10 +144,12 @@ def _buf_download_releases_impl(ctx):
output += ".exe"

ctx.report_progress("Downloading " + bin)
url = "{}/{}/{}".format(repository_url, version, bin)
download_info = ctx.download(
url = "{}/{}/{}".format(repository_url, version, bin),
url = url,
sha256 = sum,
executable = True,
canonical_id = url,
output = output,
)

Expand Down