Add sha256 support for bzlmod case#61
Merged
srikrsna-buf merged 1 commit intobufbuild:mainfrom May 15, 2024
Merged
Conversation
|
|
|
I just ran into this and would like this supported as well. We use |
srikrsna-buf
approved these changes
May 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started to use rules_rust, which uses rules_buf.
I also use bzlmod and download all dependencies ahead of time to support builds without internet access.
For this to work, all downloads from the internet need to provide sha256 hash in the download actions. I saw that for the WORKSPACE style usage, this already works (
buf_download_releasesalready supports that).This MR adds the correct hash for v1.28.1 and allows to also override the hash in addition to the version.