Add support for CEL 0.11.1 #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CEL 0.11.1 adds support for native java.time.Instant (WKT Timestamp) and java.time.Duration (WKT Duration). Update protovalidate-java to work with the new functionality, which requires that we convert types to the native representations as we're configuring the CEL runtime with `evaluateCanonicalTypesToNativeValues(true)`.
pkwarren
commented
Oct 27, 2025
| } | ||
| return out; | ||
| } | ||
| // Cel understands protobuf message so we return as is (even if it is repeated). |
Member
Author
There was a problem hiding this comment.
This no longer holds - we need to convert types in repeated messages to their native java.time.* versions.
rodaine
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CEL 0.11.1 adds support for native java.time.Instant (WKT Timestamp) and java.time.Duration (WKT Duration). Update protovalidate-java to work with the new functionality, which requires that we convert types to the native representations as we're configuring the CEL runtime with
evaluateCanonicalTypesToNativeValues(true).