Exception handling

[IvanRF]

google-analytics-java/src/main/java/com/brsanthu/googleanalytics/httpclient/ApacheHttpClientImpl.java

Lines 100 to 112 in 8ad1c1d

	try {
	httpResp = execute(req.getUrl(), new UrlEncodedFormEntity(createNameValuePairs(req), StandardCharsets.UTF_8));
	resp.setStatusCode(httpResp.getStatusLine().getStatusCode());
	} catch (Exception e) {
	if (e instanceof UnknownHostException) {
	logger.warn("Couldn't connect to Google Analytics. Internet may not be available. " + e.toString());
	} else {
	logger.warn("Exception while sending the Google Analytics tracker request " + req, e);
	}
	} finally {

There is no way of knowing what happened if a post() fails. I think you should throw the error and let the caller deal with it. Other option is to set the Exception in a new field on the HttpResponse (which will always be empty in case of a failure).

Check:

• googleapis/services/AbstractGoogleClientRequest.java#L415
• google/api/client/http/HttpRequest.java#L843

[robertvazan]

I would just add that logging is only one of several possible ways to handle errors. And it's not the best solution here, because random network failures create a lot of log noise. I would prefer to be able to count the exceptions instead and raise alarm only if there are too many of them.

[robertvazan]

As for the actual API, I recommend throwing an exception in synchronous calls and storing it in the returned Future in asynchronous calls.

If that doesn't agree with you, then the next best option is to supply exception handler in config. Default handler would implement the old behavior. People could just rethrow in the handler if they prefer the exception to be propagated.

[brsanthu]

Added this api. Any feedback welcome. fb392c2

[robertvazan]

Looks good. Could be simpler if you just propagated the exception.

[robertvazan]

The code reminds me of my own library NoException, which provides many different kinds of exception handlers. It is nevertheless trivial to adapt NoException handlers to the GoogleAnalyticsExceptionHandler interface.

[brsanthu]

NoException seems like a nice library but I would be hesitant to add another dependency. But hope functional interface would make it easy to adopt.