Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #408
I noticed the
TimeOfDayshear method was especially slow when running.apply()- which I guess is the reason why you usedFloatProgressin the code.I propose here a slight change of logic: instead of looping through all months and hour, which is computationally "costly", we append instead a column to the wind speed with the correct alpha for the hour/month, and we use vector operation to calculate the sheared column. Similar to the time series shear I guess.
But this could be done more elegantly I suppose, I probably don't use all the most optimal way to do it.
Using the demo data the
.apply()method now takes under a second compared to around 20s for the current code.All the
test_shearpassed locally.