Fix major errors found by PHPStan #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Sep 1, 2025
| IO::spin('deploying'); | ||
| $config['region'] = $region; | ||
| $deployment = $brefCloud->createDeployment($environment, $config, $gitRef, $gitMessage, $awsAccountName, $region); | ||
| $deployment = $brefCloud->createDeployment($environment, $config, $gitRef, $gitMessage, $awsAccountName); |
Contributor
Author
There was a problem hiding this comment.
createDeployment has no region parameter
szepeviktor
commented
Sep 1, 2025
|
|
||
| IO::verbose('Git ref: ' . $gitRef); | ||
| $gitMessageLog = explode("\n", $gitMessage)[0] ?? ''; | ||
| $gitMessageLog = explode("\n", $gitMessage)[0]; |
Contributor
Author
There was a problem hiding this comment.
gitMessage comes from the previous explode(), so it is always a string
szepeviktor
commented
Sep 1, 2025
Comment on lines
-188
to
+189
| $stackResults = preg_match('/stack: (.*)\n/', $infoOutput, $matches); | ||
| $regionResults = preg_match('/region: (.*)\n/', $infoOutput, $matches); | ||
| $stackResults = preg_match('/stack: (.*)\n/', $infoOutput, $stackMatches); | ||
| $regionResults = preg_match('/region: (.*)\n/', $infoOutput, $regionMatches); |
Contributor
Author
There was a problem hiding this comment.
there were 3 $matches!!!
Member
There was a problem hiding this comment.
Thank you! I think this happened after a refactor the code makes no sense indeed
Member
|
Thanks! |
Member
|
btw I'm not sure if you're using Bref or not, but always interested to talk, I might have sometimes needs for someone to jump in and help a few hours of work here and there. You can find me on slack (https://bref.sh/slack) if you want to chat more about it |
Contributor
Author
|
Glad to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mnapoli Please run PHPStan. Keeps your project running :)