This repository was archived by the owner on Jul 31, 2020. It is now read-only.
Fixed receiving objects in chunk#267
Merged
SergeyZhukovsky merged 2 commits intobrave:stagingfrom Jan 3, 2019
Merged
Conversation
Contributor
|
Tested locally with brave-core. This PR fixes brave/brave-browser#2283 and also does huge speedup for syncing of large folders. |
darkdh
reviewed
Dec 28, 2018
| Bucket: this.bucket, | ||
| Prefix: prefix | ||
| } | ||
| if (nextContinuationToken != '') { |
| contents: data.Contents, | ||
| isTruncated: data.IsTruncated | ||
| isTruncated: data.IsTruncated, | ||
| nextContinuationToken : data.NextContinuationToken |
| contents: data, | ||
| isTruncated: false | ||
| isTruncated: false, | ||
| nextContinuationToken : '' |
Member
|
not sure why browser test and coverage fails on CI. works good on my local env |
Closed
SergeyZhukovsky
approved these changes
Jan 3, 2019
Member
SergeyZhukovsky
left a comment
There was a problem hiding this comment.
Looks good to me. @darkdh @diracdeltas we decided to merge it to unblock QA from testing desktop and Android and create an issue to investigate the travis problems. All tests are passed locally and EC2 instance, they don't through travis for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://github.com/brave/browser-android-tabs/issues/925