Add NeuroPawn Knight IMU Board Support and Gain Configuration#795
Add NeuroPawn Knight IMU Board Support and Gain Configuration#795neuropawn-admin wants to merge 1 commit intobrainflow-dev:masterfrom
Conversation
Andrey1994
left a comment
There was a problem hiding this comment.
overall looks good, in addition to comments attached to code I think it would be better to have a common base class for both Knigh boards and implement different parsing logic since everything else looks the same. Good example how to do it - OpenBCISerial board and Cyton/CytonDaisy implementations
| To create such board you need to specify the following board ID and fields of BrainFlowInputParams object: | ||
|
|
||
| - :code:`BoardIds.NEUROPAWN_KNIGHT_BOARD` | ||
| - :code:`BoardIds.NEUROPAWN_KNIGHT_BOARD` or :code:`BoardIds.NEUROPAWN_KNIGHT_BOARD_IMU` |
There was a problem hiding this comment.
add new entry please to this board like its done for other devices, dont mix it with or under the same section
| gain = 12; // default gain value | ||
|
|
||
| // Parse gain from other_info if provided | ||
| if (!params.other_info.empty ()) |
There was a problem hiding this comment.
move this logic from constructor to prepare_session method and return proper error code if its invalid
| gain = 12; // default gain value | ||
|
|
||
| // Parse gain from other_info if provided | ||
| if (!params.other_info.empty ()) |
|
|
||
| from brainflow.board_shim import BoardShim, BrainFlowInputParams, BoardIds | ||
|
|
||
| class KnightBoard: |
There was a problem hiding this comment.
readmes are not used mostly in brainflow, would be better to move to python examples and I will use code snippit for blog post update, etc
This PR introduces support for the NeuroPawn Knight IMU board and adds gain configuration capabilities for Knight boards.
Key Changes: