[CLOSED] Live development: handle deleting CSS file on disk & discarding unsaved changes to CSS file

[core-ai-bot]

Issue by peterflynn
Thursday Apr 05, 2012 at 01:37 GMT
Originally opened as adobe/brackets#558

---

• Support CSS files being deleted in live development (now updates browser) -- CSSDocument now listens for Document's "deleted" event; it clears the CSS in the browser and also emits its own event that LiveDevelopment listens to so it knows to drop that file from its list of related documents
• Support discarding unsaved changes to CSS file in live development (now updates browser) -- when choosing to discard unsaved changes, the Close command (DocumentCommandHandlers.handleFileClose()) now reverts the Document to the contents on disk so that any views other than the main editor which remain open (namely, the live development connection) don't continue reflecting the unsaved (now discarded) changes.
  This replaces the refreshText("") hack we used to have in Document._makeNonEditable().
• Fixes exception in Document when unsaved changes are discarded but live development still has a ref to the doc (bug [CLOSED] Live editing ignores changes to added files #546)
• Add assertion/warning if deleting a Document doesn't release all refs

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/558/commits

[core-ai-bot]

Comment by peterflynn
Thursday Apr 05, 2012 at 01:37 GMT

---

@gruehle: Would you like to review this one?

[core-ai-bot]

Comment by gruehle
Thursday Apr 05, 2012 at 01:38 GMT

---

reviewing

[core-ai-bot]

Comment by gruehle
Thursday Apr 05, 2012 at 01:53 GMT

---

Initial review complete

[core-ai-bot]

Comment by gruehle
Thursday Apr 05, 2012 at 22:32 GMT

---

Looks good.