[CLOSED] Help for first pull request

[core-ai-bot]

Issue by pelatx
Sunday Feb 18, 2018 at 05:55 GMT
Originally opened as adobe/brackets#14121

---

Hi.

I have working properly, in a branch derived from "linux-1547" branch of Brackets-shell, the native menus with checked items in Linux (#13606, #13685).

I have been reading the documentation on how to contribute to Brackets, but I have a question:

After signing the CLA, should I create a branch of Brackets-shell "master" and make the changes there? Or should I create the branch derived from "linux-1547"?

Maybe it's an obvious question, but I'm pretty new at contributing to such large projects.

Thank you.

[core-ai-bot]

Comment by petetnt
Sunday Feb 18, 2018 at 20:31 GMT

---

Hi@pelatx,

first of all, thanks for contributing!

While I am not completely up to speed with the current state of the said branch, master got big linux updates a while back so I think it should be safe to target the PR against the master

[core-ai-bot]

Comment by pelatx
Sunday Feb 18, 2018 at 23:42 GMT

---

Thanks@petetnt.

[core-ai-bot]

Comment by petetnt
Friday Feb 23, 2018 at 09:08 GMT

---

Closing this as answered, do message back if there's more questions!