[CLOSED] Quit Fix

[core-ai-bot]

Issue by nathanial
Wednesday Jun 25, 2014 at 06:17 GMT
Originally opened as adobe#458

---

Uncommenting the GTK delete_event code appears to fix adobe/brackets#4611

I tested on Arch Linux 64-bit, using the latest brackets-shell and brackets versions.

---

nathanial included the following code: https://github.com/adobe/brackets-shell/pull/458/commits

[core-ai-bot]

Comment by redmunds
Wednesday Jun 25, 2014 at 20:16 GMT

---

@nathanial You'll need to agree to the Brackets CLA.

[core-ai-bot]

Comment by redmunds
Wednesday Jun 25, 2014 at 23:14 GMT

---

@nathanial Here are the key shutdown scenarios:

1. Brackets is open with no documents open (File > Close All). Click [x] button once to quit.

2. Brackets is open with 1 or more documents open. All changes are saved to disk (File > Save All). Click [x] button once to quit.

3. Brackets is open with 1 or more documents open with unsaved changes. Click [x] button, Brackets prompts to "Save", "Don't Save", "Cancel".
   a. Click "Save" should save changes to disk and quit
   b. Click "Don't Save" should discard changes and quit
   c. Click "Cancel" should keep changes in memory and abort quit process

   Once you are in state following 3c, you should be able to follow all of the other scenarios (1, 2, 3a, 3b, & 3c).

4. You can use Debug > New Window to open additional Brackets windows. This is in the Debug menu because it's an experimental feature, but it should be tested to make sure nothing really bad happens. Try closing from both original and new windows.

[core-ai-bot]

Comment by nathanial
Wednesday Jun 25, 2014 at 23:27 GMT

---

@redmunds Aha, cool. I will test these scenarios. Also, I agreed to the CLA.

[core-ai-bot]

Comment by nathanial
Sunday Jul 06, 2014 at 19:49 GMT

---

@redmunds Ok, I ran through all the cases and they all appear to work. For scenario 4, the only oddness is that closing the original window closes all the windows.

[core-ai-bot]

Comment by redmunds
Monday Jul 14, 2014 at 20:47 GMT

---

@nathanial

closing the original window closes all the windows

Actually, that is the expected behavior.

Just need to find someone with Linux Dev environment setup to review this PR.
cc @JeffryBooher @ingorichter @jasonsanjose

[core-ai-bot]

Comment by nathanial
Monday Jul 21, 2014 at 07:17 GMT

---

@JeffryBooher I adjusted the code and re-tested it. Appears to work.

[core-ai-bot]

Comment by peterflynn
Tuesday Jul 29, 2014 at 18:54 GMT

---

@ingorichter Said he could re-review this soon, so assigning him

[core-ai-bot]

Comment by ingorichter
Wednesday Aug 20, 2014 at 22:54 GMT

---

@nathanial I've tested this on Ubuntu 14.04 TLS 32Bit and it creates a core dump when I exit Brackets. I'm starting Brackets from the command line and that's the reason I was seeing the message about the core dump. Starting from whatever file manager doesn't give any indication about a core dump. Otherwise it seems that Brackets will exit after one click on the close button. Which is an improvement already.

[core-ai-bot]

Comment by ingorichter
Thursday Aug 21, 2014 at 00:26 GMT

---

@nathanial what have you done to compile brackets-shell on Arch Linux? I'm getting a Release/libcef.so: undefined reference to 'gcry_control@GCRYPT_1.2' when I run grunt build.

[core-ai-bot]

Comment by nathanial
Thursday Aug 21, 2014 at 00:33 GMT

---

@ingorichter I've just been doing grunt build. It's possible that either brackets-shell has changed (I notice some new commits have been made since I did this pull request) or perhaps I have a different version of gcrypt. I'll check when I get home.

[core-ai-bot]

Comment by nathanial
Thursday Aug 21, 2014 at 00:36 GMT

---

@ingorichter I'll also investigate the core dump.

[core-ai-bot]

Comment by nathanial
Thursday Aug 21, 2014 at 09:17 GMT

---

@ingorichter According to ldconfig I have these versions of gcrypt on my machine.

    libgcrypt.so.20 (libc6,x86-64) => /usr/lib/libgcrypt.so.20
    libgcrypt.so.20 (libc6) => /usr/lib32/libgcrypt.so.20
    libgcrypt.so.11 (libc6,x86-64) => /usr/lib/libgcrypt.so.11
    libgcrypt.so (libc6,x86-64) => /usr/lib/libgcrypt.so
    libgcrypt.so (libc6) => /usr/lib32/libgcrypt.so

I don't seem to get any errors when I run grunt build with this version of the code. I might have done some troubleshooting when I very first got it to compile, but I don't remember. I'll try compiling it on a fresh VM to see if there are any extra steps that need to be taken.

[core-ai-bot]

Comment by ingorichter
Saturday Aug 30, 2014 at 00:28 GMT

---

@nathanial I was able to remove a install a version of libgcrypt and compile Brackets. But there is still something wrong, since it's not starting properly. :-(

[core-ai-bot]

Comment by radorodopski
Friday Oct 24, 2014 at 03:35 GMT

---

@ingorichter , do you think you can test this without line 532?
You mentioned you got a core dump with the fix, maybe it has something to do with sending a delete_event to a window which is already in the process of closing (or already closed) because of the code on line 532.

Edit:
File --> Quit resulted in the following errors in the terminal:
[1024/064618:ERROR:browser_main_loop.cc(212)] GLib-GObject: invalid cast from 'GtkExpandedContainer' to 'GtkWindow'
[1024/064618:ERROR:browser_main_loop.cc(212)] Gtk: IA__gtk_window_present_with_time: assertion 'GTK_IS_WINDOW (window)' failed

I assumed this was because of this fix, but then I ran the latest stable release of Brackets from command line just for sanity check and it turns out the same messages are dumped even when using just "browser->GetHost()->CloseBrowser(true);" in the CloseWindow() function (i.e. without this fix).
This needs more investigation...

[core-ai-bot]

Comment by radorodopski
Friday Oct 24, 2014 at 04:44 GMT

---

Could someone point me to the right information?
I need to know how File --> Quit (from the HTML menu under Linux) is being handled.

Edit:
Contrary to what I thought, File --> Quit works fine despite the interesting error messages, which are probably an issue with CEF, not Brackets. So, just for closure, I'd like to know what happens when a user clicks File --> Quit...