Compatibility with xarray>=2022.9.0 - #276
Conversation
May help speed up copying.
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
=======================================
Coverage 69.01% 69.01%
=======================================
Files 15 15
Lines 3208 3208
Branches 790 790
=======================================
Hits 2214 2214
Misses 732 732
Partials 262 262
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xarray behaviour changed, see pydata/xarray#6999 and links from there.
Updates to xarray, meant that 'index' values were not updated when 'coordinate' values were updated. Fix by explicitly updating indexes.
|
I think with this PR the errors are gone with the latest xarray versions, but a significant slow-down is still there. I suspect the culprit is in the region operations - the tests in xarray made a lot of changes to how they handle 'indexes' recently. I wonder if the newest versions end up creating 'indexes' where they were not created before, adding overhead that way. If so, maybe we can try and avoid that happening in cases where it is not necessary? [E.g. in |
Following this comment #213 (comment), converting a few members of
Regionfrom scalarDataArraytofloatreduces the number of errors.WIP because there are still a few errors in the unit tests, and performance is worse - for some unit tests between 1.5x and 2x slower.
Fix #275.