Pull out common classes for FFT/DST transforms in some Laplacians#3261
Open
Pull out common classes for FFT/DST transforms in some Laplacians#3261
Conversation
89d4071 to
cb6260d
Compare
Also fix PCR and PCRThomas which were always using the global `nsys` array size, instead of the local array size
The Laplacian inversion solvers `LaplaceCyclic`, `LaplacePCR`, `LaplacePCR_THOMAS` all use identical code for transforming using FFTs/DSTs. This commit pulls out that common code to make it easier to maintain. Also, make the transforms parallel-Z-ready by using the Z guard cells as offsets
bac2474 to
83d6660
Compare
Member
Author
|
Now also adds a couple of tests for |
| localmesh->getXcomm()); | ||
| // Subtract average from kz=0 modes | ||
| for (int y = 0; y < ny; y++) { | ||
| BoutReal avg = global[y] / global[ny]; |
Contributor
There was a problem hiding this comment.
warning: variable 'avg' of type 'BoutReal' (aka 'double') can be declared 'const' [misc-const-correctness]
Suggested change
| BoutReal avg = global[y] / global[ny]; | |
| BoutReal const avg = global[y] / global[ny]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Laplacian inversion solvers
LaplaceCyclic,LaplacePCR,LaplacePCR_THOMASall use identical code for transforming using FFTs/DSTs. This commit pulls out that common code to make it easier to maintain.Also, make the transforms parallel-Z-ready by using the Z guard cells as offsets