Update LevelFormatter docs and add tests for formatting string.#85
Closed
jkulhanek wants to merge 1 commit intoborntyping:mainfrom
Closed
Update LevelFormatter docs and add tests for formatting string.#85jkulhanek wants to merge 1 commit intoborntyping:mainfrom
jkulhanek wants to merge 1 commit intoborntyping:mainfrom
Conversation
Owner
|
This looks great, though has broken tests on Python 2: (Sorry, at some point automated tests for this repository have broken. Tests can be run with Tox, though need various versions of Python installed.) |
7ddb979 to
86da30b
Compare
Owner
|
Tests that this works as expected have been added in 6.0.0a2. (This is a prerelease and may change before version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR the fix for #84 is implemented with tests.