Avoid unnecessary requires

[taylor1791]

We encountered a problem with webworkify-webpack. By requireing every module, it is forcing all modules to be initialized. Some of our modules have assumptions about when they are initialized. In particular, they have to be initialized after we use something that uses webworkify-webpack as a dependency.

To fix this, I purpose that we avoid requireing the modules by doing a simple check to see if the module "looks like" the right one. Making wrapperFuncString.indexOf(fnString) > -1 a necessary condition for the require address this issue. The subsequent logic is updated to behave appropriately since the conditions are now reversed.

This fixes the problem and does not change existing behavior as far as I know. This can be considered a breaking change. However, it is one that reverts the behavior to what I and most users expect.

[taylor1791]

Moving this line because it avoids stringifying the function numerous times.

[borisirota]

Thanks ! available in version 1.1.0.

Please take a look at the caveat I added to the README.

[taylor1791]

Ah! Good thinking about the caveat. I forgot about that option in webpack.

[yocontra]

Is there any way to get around this? Builds are now 60+ seconds when they used to be 400ms because of this :(

[borisirota]

@contra please give more info. webworkify-webpack is a runtime worker builder. It shouldn't affect the webpack build.

[yocontra]

@borisirota You can't use efficient sourcemaps after this was merged, there's a note in the README about it. It does affect webpack build perf by placing that limitation on anyone who uses it.

[borisirota]

@contra you are right and you can get around this by using v1.0.6.

[borisirota]

@contra in the new v2 there is no limitation on the devtool options (eval can be used as well)