Skip to content

Retire dedicated dedup Jepsen workflow#981

Merged
bootjp merged 1 commit into
mainfrom
ci/retire-dedup-jepsen-workflow
Jun 26, 2026
Merged

Retire dedicated dedup Jepsen workflow#981
bootjp merged 1 commit into
mainfrom
ci/retire-dedup-jepsen-workflow

Conversation

@bootjp

@bootjp bootjp commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the dedicated scheduled dedup Jepsen workflow.
  • Let the standard scheduled Jepsen workflow exercise the default Redis/DynamoDB dedup-on path by dropping the explicit opt-out env vars.
  • Update design docs to record the post-flip CI cleanup.

Validation

  • actionlint .github/workflows/jepsen-test-scheduled.yml
  • git diff --check
  • Confirmed .github/workflows no longer references the dedup opt-out env vars or the deleted workflow.

Summary by CodeRabbit

  • Chores
    • Simplified scheduled Jepsen testing by removing a retired dedicated dedup-mode job.
    • Updated the remaining scheduled test to use the default dedup behavior instead of forcing an override.
  • Documentation
    • Aligned design docs with the new scheduled test coverage and rollout status.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18416534-2e1e-4ef8-8466-66be6e36f3c0

📥 Commits

Reviewing files that changed from the base of the PR and between 8ce61e0 and 95a588b.

📒 Files selected for processing (5)
  • .github/workflows/jepsen-test-scheduled-dedup.yml
  • .github/workflows/jepsen-test-scheduled.yml
  • docs/design/2026_05_21_proposed_txn_secondary_idempotency.md
  • docs/design/2026_06_03_partial_dynamodb_onephase_dedup.md
  • docs/design/2026_06_10_proposed_redis_onephase_dedup_default_on.md

📝 Walkthrough

Walkthrough

Removes the dedicated Jepsen dedup workflow, drops explicit dedup-off env vars from the remaining scheduled workflow, and updates the design docs to describe the default-on dedup rollout and cleanup.

Changes

Jepsen dedup workflow retirement

Layer / File(s) Summary
Scheduled workflow baseline
.github/workflows/jepsen-test-scheduled.yml, docs/design/2026_05_21_proposed_txn_secondary_idempotency.md
Removes the explicit ELASTICKV_*_ONEPHASE_DEDUP=0 settings from the scheduled Jepsen workflow and updates the secondary idempotency doc to reference the general scheduled workflow for dedup-mode coverage.
DynamoDB rollout notes
docs/design/2026_06_03_partial_dynamodb_onephase_dedup.md
Updates the DynamoDB rollout validation and decision log to describe default-on dedup coverage in the scheduled workflow and the removal of the dedicated dedup workflow.
Redis rollout notes
docs/design/2026_06_10_proposed_redis_onephase_dedup_default_on.md
Updates the Redis default-on narrative, control-workflow discussion, cleanup note, and rollout instructions to match the retired dedicated dedup workflow and the remaining scheduled workflow path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • bootjp/elastickv#943 — Touches the same Jepsen scheduled-workflow dedup baseline for Redis one-phase txn dedup.
  • bootjp/elastickv#970 — Modifies the dedicated dedup-mode Jepsen workflow that this PR removes.
  • bootjp/elastickv#973 — Updates the same Jepsen scheduled workflow and dedup behavior around the rollout.

Suggested labels

codex

Poem

I twitched my nose at cron-time light,
then tucked the old dedup flags out of sight.
One schedule hums, the docs agree,
and carrots bloom in CI.
🐇

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/retire-dedup-jepsen-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several design documents to reflect the post-flip CI cleanup. Specifically, it documents the retirement of the dedicated dedup-mode Jepsen workflows and the removal of the legacy-path opt-out environment variables from the general scheduled Jepsen workflow, which now covers the default dedup-on path. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@bootjp bootjp marked this pull request as ready for review June 26, 2026 07:33
@bootjp bootjp merged commit 85f9890 into main Jun 26, 2026
11 of 12 checks passed
@bootjp bootjp deleted the ci/retire-dedup-jepsen-workflow branch June 26, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant