container ukify followup
#1972
Merged
container ukify followup
#1972
+77
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Eckersberg <[email protected]>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces some nice refactorings that improve code clarity and type safety, especially with the introduction of the KernelPath enum. The changes to the seal-uki shell script also make it more readable. I have one minor suggestion for an unnecessary and likely non-compiling change in crates/lib/src/kernel.rs.
This just clarifies things in a few places to distinguish between a UKI which has just a single path versus a traditional kernel with separate vmlinuz and initramfs. Also renames `find_uki_filename` to `find_uki_path` and updates the return type to use `Utf8PathBuf` instead of just `String`. Signed-off-by: John Eckersberg <[email protected]>
882417d to
efbd374
Compare
cgwalters
approved these changes
Feb 3, 2026
| Uki(Utf8PathBuf), | ||
| Vmlinuz { | ||
| path: Utf8PathBuf, | ||
| initramfs: Utf8PathBuf, |
Collaborator
There was a problem hiding this comment.
This one is probably still technically Option...
Collaborator
Author
There was a problem hiding this comment.
Yeah true. I'll merge as-is but if someone comes along and wants their localyesconfig kernel supported I guess we can revisit 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits, just some improvements after #1960