Conversation
|
I built GCC from source, |
|
Just checking.... does libstdc++3 encase |
|
It does have an |
|
Ah, nothing useful there then, this all looks good to me then. |
| #endif | ||
|
|
||
| #if defined(BOOST_CSTDFLOAT_HAS_INTERNAL_FLOAT128_T) && defined(BOOST_MATH_USE_FLOAT128) && !defined(BOOST_CSTDFLOAT_NO_LIBQUADMATH_SUPPORT) | ||
| #if defined(BOOST_CSTDFLOAT_HAS_INTERNAL_FLOAT128_T) && defined(BOOST_MATH_USE_FLOAT128) && !defined(BOOST_CSTDFLOAT_NO_LIBQUADMATH_SUPPORT) && (!defined(__GNUC__) || (defined(__GNUC__) && __GNUC__ < 14)) |
There was a problem hiding this comment.
This check seems wrong. The new numeric_limits<__float128> specialization will be enabled when using new libstdc++ headers with Clang, which does not define __GNUC__ to 14 (it can be told to use any value, but by default it defines it to 4).
There was a problem hiding this comment.
Checking _GLIBCXX_RELEASE < 14 would be more correct, as that is determined by the libstdc++ headers, not by the compiler including them.
FWIW the current code uses slightly different conditions: That was changed by https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=6261d10521f9fdc2a43d54b4dc365025288aa8e9 |
Closes: #992