fix end of workday critical bug#84
Merged
bokmann merged 3 commits intobokmann:masterfrom Jun 10, 2014
dimelo:fix-critical-bug-end-of-day-parsing-error
Merged
fix end of workday critical bug#84bokmann merged 3 commits intobokmann:masterfrom dimelo:fix-critical-bug-end-of-day-parsing-error
bokmann merged 3 commits intobokmann:masterfrom
dimelo:fix-critical-bug-end-of-day-parsing-error
Conversation
bokmann
added a commit
that referenced
this pull request
Jun 10, 2014
…g-error fix end of workday critical bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We noticed some weird behavior when computing business hours in our production app.
I found the culprit :
It was returning '23:59:59' when a end of day work hour is '20:00'...
I also added a fixed when computing business hours between ActiveSupport::TimeWithZone
Specs are green on ruby 2.1.1