Skip to content

[Snyk] Security upgrade io.undertow:undertow-servlet from 1.4.18.Final to 2.3.21.Final #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bogarin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade io.undertow:undertow-servlet from 1.4.18.Final to 2.3.21.Final #5256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion undertow/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
</build>

<properties>
<undertow-servlet.version>1.4.18.Final</undertow-servlet.version>
<undertow-servlet.version>2.3.21.Final</undertow-servlet.version>
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major version upgrade from Undertow 1.x to 2.x, which introduces breaking changes. Key concerns:

  1. Java version requirement: Undertow 2.x requires Java 11 as minimum, but the parent pom.xml specifies Java 1.8 (line 1454 in pom.xml). This upgrade will likely cause compilation failures.

  2. Security API changes: The code in SecureServer.java and CustomIdentityManager.java uses Undertow's security APIs (IdentityManager, AuthenticationMechanism, SecurityContext), which have undergone significant changes between versions 1.x and 2.x. These may require code modifications.

  3. WebSocket API changes: SocketServer.java uses WebSocket APIs that may have changed in the major version upgrade.

  4. No test coverage: There are no test files to verify that the application still works correctly after the upgrade.

  5. Historical context: The undertow module is currently commented out in the parent pom.xml (line 716) due to build issues since 2019, suggesting this module may not be actively maintained.

Before merging this security fix, the code should be tested to ensure it compiles and runs correctly with Undertow 2.3.21.Final. Consider reviewing the Undertow migration guide and updating any deprecated or changed APIs.

Copilot uses AI. Check for mistakes.
<maven-shade-plugin.version>2.4.3</maven-shade-plugin.version>
<maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
</properties>
Expand Down