Skip to content

[Snyk] Fix for 2 vulnerabilities #5249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bogarin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #5249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@
</goals>
</pluginExecutionFilter>
<action>
<ignore></ignore>
<ignore/>
</action>
</pluginExecution>
<pluginExecution>
Expand All @@ -281,7 +281,7 @@
</goals>
</pluginExecutionFilter>
<action>
<ignore></ignore>
<ignore/>
</action>
</pluginExecution>
</pluginExecutions>
Expand Down Expand Up @@ -1445,7 +1445,7 @@

<!-- logging -->
<org.slf4j.version>1.7.32</org.slf4j.version>
<logback.version>1.2.6</logback.version>
<logback.version>1.5.25</logback.version>
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logback 1.5.x requires Java 11 or higher, but this project is configured to use Java 1.8 (see line 1454 where java.version is set to 1.8). Additionally, Logback 1.5.x requires SLF4J 2.0+, but this project is using SLF4J 1.7.32 (see line 1447). This version upgrade will cause build failures and runtime compatibility issues. Consider either:

  1. Upgrading to Logback 1.4.x (which supports Java 8 and SLF4J 1.7.x) to address security vulnerabilities while maintaining compatibility, or
  2. Upgrading the entire project to Java 11+ and SLF4J 2.0+ as part of a larger migration effort
Suggested change
<logback.version>1.5.25</logback.version>
<logback.version>1.4.14</logback.version>

Copilot uses AI. Check for mistakes.

<!-- plugins -->
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
Expand Down
2 changes: 1 addition & 1 deletion testing-modules/assertion-libraries/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@

<properties>
<truth.version>0.32</truth.version>
<assertj-guava.version>3.4.0</assertj-guava.version>
<assertj-guava.version>3.27.7</assertj-guava.version>
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssertJ Guava 3.27.x requires Java 11 or higher, but this project is configured to use Java 1.8 (see line 1454 in the root pom.xml where java.version is set to 1.8). This version upgrade will cause build failures. Consider either:

  1. Upgrading to a version of assertj-guava that supports Java 8 while addressing the XXE vulnerability (if available), or
  2. Upgrading the testing-modules/assertion-libraries module to use Java 11+ separately from the main project

Copilot uses AI. Check for mistakes.
<assertj-generator.version>2.1.0</assertj-generator.version>
<javalite.version>1.4.13</javalite.version>
<jgotesting.version>0.12</jgotesting.version>
Expand Down