Skip to content

[Snyk] Fix for 3 vulnerabilities #5248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bogarin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #5248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@
</goals>
</pluginExecutionFilter>
<action>
<ignore></ignore>
<ignore/>
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting change from opening and closing tags to a self-closing tag is functionally equivalent and valid XML. While this is a stylistic improvement, it appears unrelated to the security vulnerability fixes described in the PR. Consider whether these formatting changes should be in a separate PR focused on code cleanup, rather than mixed with security fixes. This helps maintain clear PR history and easier rollback if needed.

Copilot uses AI. Check for mistakes.
</action>
</pluginExecution>
<pluginExecution>
Expand All @@ -281,7 +281,7 @@
</goals>
</pluginExecutionFilter>
<action>
<ignore></ignore>
<ignore/>
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting change from opening and closing tags to a self-closing tag is functionally equivalent and valid XML. While this is a stylistic improvement, it appears unrelated to the security vulnerability fixes described in the PR. Consider whether these formatting changes should be in a separate PR focused on code cleanup, rather than mixed with security fixes. This helps maintain clear PR history and easier rollback if needed.

Suggested change
<ignore/>
<ignore></ignore>

Copilot uses AI. Check for mistakes.
</action>
</pluginExecution>
</pluginExecutions>
Expand Down Expand Up @@ -1445,7 +1445,7 @@

<!-- logging -->
<org.slf4j.version>1.7.32</org.slf4j.version>
<logback.version>1.2.6</logback.version>
<logback.version>1.5.25</logback.version>
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade from Logback 1.2.6 to 1.5.25 introduces a significant compatibility concern. Logback 1.5.x requires SLF4J 2.0.x or higher, but this project is using SLF4J 1.7.32. According to Logback's official compatibility documentation, Logback 1.5.x is designed to work with SLF4J 2.0.x API. Using Logback 1.5.25 with SLF4J 1.7.32 may lead to runtime errors or unexpected behavior.

To properly fix the security vulnerability, you should either:

  1. Upgrade to Logback 1.2.13 (the latest 1.2.x version) which is compatible with SLF4J 1.7.x and addresses the security issue, or
  2. Upgrade both Logback to 1.5.25 AND SLF4J to 2.0.x (e.g., 2.0.16) to maintain compatibility.

The first option (Logback 1.2.13) would be less risky as it avoids potential breaking changes from the SLF4J major version upgrade.

Suggested change
<logback.version>1.5.25</logback.version>
<logback.version>1.2.13</logback.version>

Copilot uses AI. Check for mistakes.

<!-- plugins -->
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
Expand Down