Skip to content

[Snyk] Fix for 2 vulnerabilities#5247

Open
bogarin wants to merge 1 commit intomasterfrom
snyk-fix-279eb4e03df81506a11049db55f88032
Open

[Snyk] Fix for 2 vulnerabilities#5247
bogarin wants to merge 1 commit intomasterfrom
snyk-fix-279eb4e03df81506a11049db55f88032

Conversation

@bogarin
Copy link
Copy Markdown
Owner

@bogarin bogarin commented Jan 28, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the maven dependencies of this project.

Snyk changed the following file(s):

  • pom.xml

Vulnerabilities that will be fixed with an upgrade:

Issue Score Upgrade
medium severity XML External Entity (XXE) Injection
SNYK-JAVA-ORGASSERTJ-15102413
  535   No Path Found No Known Exploit
low severity External Initialization of Trusted Variables or Data Stores
SNYK-JAVA-CHQOSLOGBACK-15062482
  290   ch.qos.logback:logback-classic:
1.2.6 -> 1.5.25
ch.qos.logback:logback-core:
1.2.6 -> 1.5.25
No Path Found No Known Exploit

Vulnerabilities that could not be fixed

  • Upgrade:
    • Could not upgrade org.springframework.cloud:spring-cloud-starter-dataflow-server-local@1.3.1.RELEASE to org.springframework.cloud:spring-cloud-starter-dataflow-server-local@1.7.3.RELEASE; Reason could not apply upgrade, dependency is managed externally ; Location: https://maven-central.storage-download.googleapis.com/maven2/org/springframework/cloud/spring-cloud-dataflow-dependencies/1.3.1.RELEASE/spring-cloud-dataflow-dependencies-1.3.1.RELEASE.pom

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 XML External Entity (XXE) Injection

Copilot AI review requested due to automatic review settings January 28, 2026 06:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This Snyk-generated PR attempts to address 2 security vulnerabilities by upgrading logback from version 1.2.6 to 1.5.25 to fix a low-severity "External Initialization of Trusted Variables or Data Stores" vulnerability (SNYK-JAVA-CHQOSLOGBACK-15062482). The PR also includes minor XML formatting changes.

Changes:

  • Updated logback.version from 1.2.6 to 1.5.25
  • Cleaned up XML formatting (converted <ignore></ignore> to self-closing <ignore/> tags)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pom.xml
<!-- logging -->
<org.slf4j.version>1.7.32</org.slf4j.version>
<logback.version>1.2.6</logback.version>
<logback.version>1.5.25</logback.version>
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading logback from 1.2.6 to 1.5.25 introduces a compatibility issue. Logback 1.5.x requires SLF4J 2.0.x or higher, but this project uses SLF4J 1.7.32 (defined at line 1447). This version mismatch will cause runtime errors.

To fix this issue, either:

  1. Update slf4j to version 2.0.0 or higher (e.g., 2.0.16) along with logback 1.5.25, or
  2. Use logback 1.3.x (e.g., 1.3.14) which is compatible with SLF4J 1.7.x and still addresses the security vulnerability

Logback 1.3.x is the maintenance branch for SLF4J 1.7.x compatibility, while 1.4.x and 1.5.x require SLF4J 2.0.x.

Suggested change
<logback.version>1.5.25</logback.version>
<logback.version>1.3.14</logback.version>

Copilot uses AI. Check for mistakes.
Comment thread pom.xml
<!-- logging -->
<org.slf4j.version>1.7.32</org.slf4j.version>
<logback.version>1.2.6</logback.version>
<logback.version>1.5.25</logback.version>
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description indicates that this PR will fix an XXE vulnerability in AssertJ (SNYK-JAVA-ORGASSERTJ-15102413), but the assertj.version property (line 1440) remains at 3.21.0 and is not updated in this PR. The PR description notes "No Path Found" for this vulnerability, suggesting it cannot be automatically fixed.

This creates a discrepancy: the PR claims to fix 2 vulnerabilities but only actually updates dependencies for 1 vulnerability (logback). Consider either:

  1. Updating the PR description to clarify that only the logback vulnerability is being fixed, or
  2. Manually upgrading AssertJ to a version that addresses the XXE vulnerability if such a version exists

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants