Skip to content

[Snyk] Fix for 2 vulnerabilities #5244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bogarin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #5244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion persistence-modules/spring-hibernate-3/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<org.springframework.version>4.3.4.RELEASE</org.springframework.version>
<javassist.version>3.21.0-GA</javassist.version>
<!-- persistence -->
<hibernate.version>3.6.10.Final</hibernate.version>
<hibernate.version>5.3.38.Final</hibernate.version>
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading hibernate-core from 3.6 to 5.3 in this module is inconsistent with the rest of the module, which is explicitly built around Spring's org.springframework.orm.hibernate3.* integration and Hibernate 3 configuration (e.g., hibernate-configuration-3.0.dtd). With Hibernate 5.3 this setup is expected to break; to make this upgrade work you’ll need to migrate the Spring integration/configuration to the Hibernate 5 variant (e.g., Spring ORM Hibernate 5 support / updated config files), or keep this module on the Hibernate 3 line and address the vulnerability another way (exclude/disable the module, isolate it from production builds, etc.).

Suggested change
<hibernate.version>5.3.38.Final</hibernate.version>
<hibernate.version>3.6.10.Final</hibernate.version>

Copilot uses AI. Check for mistakes.
<mysql-connector-java.version>5.1.40</mysql-connector-java.version>
<tomcat-dbcp.version>8.5.8</tomcat-dbcp.version>
</properties>
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@
</goals>
</pluginExecutionFilter>
<action>
<ignore></ignore>
<ignore/>
</action>
</pluginExecution>
<pluginExecution>
Expand All @@ -281,7 +281,7 @@
</goals>
</pluginExecutionFilter>
<action>
<ignore></ignore>
<ignore/>
</action>
</pluginExecution>
</pluginExecutions>
Expand Down Expand Up @@ -1445,7 +1445,7 @@

<!-- logging -->
<org.slf4j.version>1.7.32</org.slf4j.version>
<logback.version>1.2.6</logback.version>
<logback.version>1.5.25</logback.version>
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping logback to 1.5.25 while keeping org.slf4j.version at 1.7.32 is very likely incompatible: newer Logback lines are built to work with SLF4J 2.x and can fail at runtime (e.g., missing SLF4J service provider classes) when forced onto SLF4J 1.7 via dependency management. Align the SLF4J + Logback versions (upgrade SLF4J accordingly, or pick a Logback version that is compatible with SLF4J 1.7 / Java 8).

Suggested change
<logback.version>1.5.25</logback.version>
<logback.version>1.2.13</logback.version>

Copilot uses AI. Check for mistakes.

<!-- plugins -->
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
Expand Down