Skip to content

Add manual PartialOrd impl for FiniteF64 #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nekevss merged 2 commits into from
Dec 11, 2025
Merged

Add manual PartialOrd impl for FiniteF64 #649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c5f162
Fix clippy lint
nekevss Dec 11, 2025
c59a10f
Merge branch 'main' into fix-clippy-error
nekevss Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/primitive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use crate::{error::ErrorMessage, TemporalError, TemporalResult};
use num_traits::float::FloatCore;
use num_traits::{AsPrimitive, FromPrimitive, PrimInt};

#[derive(Debug, Default, Clone, Copy, PartialEq, PartialOrd)]
#[derive(Debug, Default, Clone, Copy, PartialEq)]
pub struct FiniteF64(pub(crate) f64);

impl core::fmt::Display for FiniteF64 {
Expand Down Expand Up @@ -222,7 +222,6 @@ impl PartialOrd<f64> for FiniteF64 {

impl Eq for FiniteF64 {}

#[allow(clippy::derive_ord_xor_partial_ord)]
impl Ord for FiniteF64 {
fn cmp(&self, other: &Self) -> Ordering {
match self.0.partial_cmp(&other.0) {
Expand All @@ -235,6 +234,12 @@ impl Ord for FiniteF64 {
}
}

impl PartialOrd for FiniteF64 {
fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
Some(self.cmp(other))
}
}

/// An intermediate primitive type for calculating
/// double64 results.
#[derive(Debug, Clone, Copy)]
Expand Down