YearMonth addition: Use ISO parameters, not calendared parameters, when subtracting#645
Merged
nekevss merged 1 commit intoboa-dev:mainfrom Dec 9, 2025
Merged
Conversation
…en subtracting The spec wants us to do this in calendar space
a24d1b4 to
ea42c6b
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 9, 2025
Uplift boa-dev/temporal#645 Bug: 401065166 Change-Id: I19e4ef76a5b9f1f44279682ba42d085f42ec5832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7238054 Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1555809}
nekevss
approved these changes
Dec 9, 2025
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 9, 2026
Uplift boa-dev/temporal#645 Bug: 401065166 Change-Id: I19e4ef76a5b9f1f44279682ba42d085f42ec5832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7238054 Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1555809} NOKEYCHECK=True GitOrigin-RevId: 392665fe043ac4ce33d44d6a7acdd3a425d5ec28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec wants us to do this in calendar space
Fixes #643