Skip to content

Attempt to handle the "completely contained within" timezone rule#629

Merged
nekevss merged 6 commits intoboa-dev:mainfrom
Manishearth:more-timezones
Nov 15, 2025
Merged

Attempt to handle the "completely contained within" timezone rule#629
nekevss merged 6 commits intoboa-dev:mainfrom
Manishearth:more-timezones

Conversation

@Manishearth
Copy link
Copy Markdown
Contributor

@Manishearth Manishearth commented Nov 13, 2025

Fixes #627

This does two things:

  • It starts including the backzone file, which fixes things like Chuuk/Truk
    • I'm including it unconditionally in zoneinfo_rs. I could instead include it conditionally in datagen.rs as an additional thing we tack on. Thoughts?
  • It has hardcoded overrides for the three packrat timezones. These were verified from https://github.com/unicode-org/cldr/blob/main/common/bcp47/timezone.xml.

@Manishearth Manishearth requested a review from nekevss November 13, 2025 18:26
@Manishearth
Copy link
Copy Markdown
Contributor Author

Manishearth commented Nov 13, 2025

I added a test against CLDR

@Manishearth Manishearth force-pushed the more-timezones branch 4 times, most recently from 03f73f9 to 17133f7 Compare November 13, 2025 19:34
@Manishearth Manishearth mentioned this pull request Nov 13, 2025
Closed
nekevss
nekevss reviewed Nov 14, 2025
View reviewed changes
Comment thread zoneinfo/src/lib.rs Outdated
@Manishearth Manishearth requested a review from nekevss November 14, 2025 00:06
nekevss
nekevss approved these changes Nov 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nekevss nekevss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for looking into this

@nekevss nekevss merged commit cb81c9e into boa-dev:main Nov 15, 2025
8 checks passed
aarongable pushed a commit to chromium/chromium that referenced this pull request Nov 17, 2025
@Manishearth
Uplift patch to handle "completely contained within" timezone rule
a32e1b1 
Uplifts boa-dev/temporal#629

Last legitimate test failure.

Bug: 401065166
Change-Id: If79acad9f7dbb54f812d27dba5459ddc3f87a9f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7159754
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Manish Goregaokar <manishearth@google.com>
Cr-Commit-Position: refs/heads/main@{#1545956}
mohd-akram pushed a commit to gsource-mirror/chromium-src-third_party-rust that referenced this pull request Jan 9, 2026
@Manishearth @copybara-github
Uplift patch to handle "completely contained within" timezone rule
e151a28 
Uplifts boa-dev/temporal#629

Last legitimate test failure.

Bug: 401065166
Change-Id: If79acad9f7dbb54f812d27dba5459ddc3f87a9f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7159754
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Manish Goregaokar <manishearth@google.com>
Cr-Commit-Position: refs/heads/main@{#1545956}
NOKEYCHECK=True
GitOrigin-RevId: a32e1b16ec6dad8491a97855b56e1f7b7ec21776
@robertbastian
Copy link
Copy Markdown
Contributor

robertbastian commented Feb 11, 2026

  • It starts including the backzone file, which fixes things like Chuuk/Truk

I don't think this is correct. The backzone file contains lower-quality data from before 1970. The Chuuk/Truk alias in is backward, the only thing that backzone adds is Asia/Hanoi, a zone that only differs pre-1970 and that is not usually included in TZDB distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nekevss nekevss nekevss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle "completely contained within geographic area" time zone rules

3 participants

@Manishearth @robertbastian @nekevss