remove unneeded clone in TzdbResolver::get#628
Merged
nekevss merged 1 commit intoboa-dev:mainfrom Nov 18, 2025
Merged
Conversation
nekevss
reviewed
Nov 17, 2025
1cb021a to
9947d18
Compare
nekevss
approved these changes
Nov 18, 2025
in the future the dx can be improved once `RwLockReadGuard::map` is stabilized, see rust-lang/rust#117108
9947d18 to
281c22d
Compare
Contributor
Author
Ah, yeah... somehow missed that. Sorry |
Member
Don't worry it happens after just about every merge to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that every time when a timezone is accessed via
ResolvedIdin the cache, the fullTzifstruct is cloned, which contains multiple allocations.Just from poking around in the code, this seems to happen quite frequently, for example when a new
ZonedDateTimeis created.In the future the dx can be improved once
RwLockReadGuard::mapis stabilized, see rust-lang/rust#117108, though I think it will take some time.