Fix returned duration sign for non-ISO date arithmetic#618
Merged
Conversation
Member
|
This should close #617, correct? |
Contributor
Author
|
Yes! |
d7ee795 to
ab5d76c
Compare
ab5d76c to
5f1ae8b
Compare
nekevss
approved these changes
Nov 4, 2025
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 4, 2025
Uplifts boa-dev/temporal#618, boa-dev/temporal#619 to fix the remaining test262 failures. Bug: 401065166 Change-Id: Ie94eb956b4a0327d9e91c7ca43774cc4ecf3bf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7120501 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1540332}
jmajnert
pushed a commit
to jmajnert/chromium
that referenced
this pull request
Nov 6, 2025
Uplifts boa-dev/temporal#618, boa-dev/temporal#619 to fix the remaining test262 failures. Bug: 401065166 Change-Id: Ie94eb956b4a0327d9e91c7ca43774cc4ecf3bf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7120501 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1540332}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 9, 2026
Uplifts boa-dev/temporal#618, boa-dev/temporal#619 to fix the remaining test262 failures. Bug: 401065166 Change-Id: Ie94eb956b4a0327d9e91c7ca43774cc4ecf3bf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7120501 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1540332} NOKEYCHECK=True GitOrigin-RevId: 089c57425a7ca78e324d8735ced9cc51e65b9b5c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprised this didn't break more things.
Fixes #617