Constrain durations into a range that will produce valid Temporal dates before passing to ICU4X#615
Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom Nov 1, 2025
Conversation
ccb40c3 to
097b731
Compare
…es before passing to ICU4X
097b731 to
2c629ac
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 1, 2025
This uplifts boa-dev/temporal#615. It ought to prevent debug assertions and pathologically slow behavior when attempting to do date arithmetic with very large durations. These durations are too large to produce a valid in-range date anyway, so we can proactively error when we see them. With this patch I *believe* we should be fuzzer-error free, but of course we'll only know after running the fuzzer for a while. Change-Id: Id2426776556b4451335b7d0f775b43b3c5b92ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7108948 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Manish Goregaokar <manishearth@google.com> Cr-Commit-Position: refs/heads/main@{#1539036}
This was referenced Nov 4, 2025
jmajnert
pushed a commit
to jmajnert/chromium
that referenced
this pull request
Nov 6, 2025
This uplifts boa-dev/temporal#615. It ought to prevent debug assertions and pathologically slow behavior when attempting to do date arithmetic with very large durations. These durations are too large to produce a valid in-range date anyway, so we can proactively error when we see them. With this patch I *believe* we should be fuzzer-error free, but of course we'll only know after running the fuzzer for a while. Change-Id: Id2426776556b4451335b7d0f775b43b3c5b92ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7108948 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Manish Goregaokar <manishearth@google.com> Cr-Commit-Position: refs/heads/main@{#1539036}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 9, 2026
This uplifts boa-dev/temporal#615. It ought to prevent debug assertions and pathologically slow behavior when attempting to do date arithmetic with very large durations. These durations are too large to produce a valid in-range date anyway, so we can proactively error when we see them. With this patch I *believe* we should be fuzzer-error free, but of course we'll only know after running the fuzzer for a while. Change-Id: Id2426776556b4451335b7d0f775b43b3c5b92ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7108948 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Manish Goregaokar <manishearth@google.com> Cr-Commit-Position: refs/heads/main@{#1539036} NOKEYCHECK=True GitOrigin-RevId: 50036dd5bea6438c17c68c50d6ea31a3f5c7ab5f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some panics we should be avoiding here
unicode-org/icu4x#7206