Fix serialization of durations with zero seconds and nonzero subseconds#610
Merged
nekevss merged 1 commit intoboa-dev:mainfrom Oct 30, 2025
Merged
Conversation
Previously, if a duration had nonzero minutes or higher, zero seconds, and nonzero subseconds, the subseconds would not be printed. See test262 tests at tc39/test262#4620. Also adds simple inline tests for this case.
c47b144 to
2c052c4
Compare
philwo
pushed a commit
to philwo/chromium
that referenced
this pull request
Nov 6, 2025
Minor issue caught by snapshot testing. Uplifts boa-dev/temporal#610 Bug: 401065166 Change-Id: Ia571f6bcac5a11264b69f5ffd9209c98eceecb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7127120 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Manish Goregaokar <manishearth@google.com> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1541459}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 9, 2026
Minor issue caught by snapshot testing. Uplifts boa-dev/temporal#610 Bug: 401065166 Change-Id: Ia571f6bcac5a11264b69f5ffd9209c98eceecb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7127120 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Manish Goregaokar <manishearth@google.com> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1541459} NOKEYCHECK=True GitOrigin-RevId: c3e1f3b66b2b3a4a6a7262431311d165905ba40b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a duration had nonzero minutes or higher, zero seconds, and nonzero subseconds, the subseconds would not be printed.
See test262 tests at tc39/test262#4620. Also adds simple inline tests for this case.