fix: allow passing &dyn TimeZoneProvider in arguments#599
Merged
Conversation
Member
|
Thanks for make the adjustments here! I don't think main is in a releasable state currently though as it is setup for the ICU4X 2.1 release. Although, we could probably cherry pick the commit to a different branch for the 0.1.1 release. I haven't exactly looked to deep into what would go into that process with the current release workflow. |
Member
Author
|
@nekevss I'm not too worried about not releasing immediately, it's just to avoid making too many breaking changes before the 1.0. We can pin to a commit in Boa like we always do |
Merged
nekevss
approved these changes
Oct 28, 2025
Member
nekevss
left a comment
There was a problem hiding this comment.
Looks good, but needs a rebase
0eb4d2b to
49be7f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested the crate using
cargo semver-checksand everything looks good, so we could release this change in a 0.1.1 version if we want to.