Conversation
Contributor
|
I think this is a good idea |
Member
Author
|
I mentioned this on Matrix, but just so that it's visible here. Thoughts on the actual method names? For instance, in theory this could also be changed to. struct Temporal;
impl Temporal {
fn now_with_system_fallback() -> Now<LocalHostSystem> {
todo!()
}
fn now_with_utc_fallback() -> Now<UtcHostSystem> {
todo!()
}
} |
Contributor
|
This isn't fallback, is it? It's the system Now or the UTC Now? |
Member
Author
|
Hmmmmm, that's true it's more of a host default value. It's more so that if no But calling it a fallback, then makes the |
Manishearth
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put together this PR based on some ongoing discussion around the host system returned by
Temporal::now().I think this may be the right direction for this API in temporal_rs. But thought I'd at least put it together for further discussion.