re-export DefaultHostSystem#590
Merged
nekevss merged 1 commit intoboa-dev:mainfrom Sep 25, 2025
Merged
Conversation
33d551f to
0e297dc
Compare
nekevss
requested changes
Sep 25, 2025
Member
nekevss
left a comment
There was a problem hiding this comment.
Thanks! Just to confirm, is this for access to the default host system implementation without the sys flag?
Had one issue with re-exporting the EmptyHostSystem, but I think I'm fine with exporting the DefaultHostSystem.
|
|
||
|
|
||
| #[doc(inline)] | ||
| pub use host::EmptyHostSystem; |
Member
There was a problem hiding this comment.
issue: we should not to export this type.
It's mostly meant as a test type for documentation purposes. Even more so, it definitely shouldn't be in the lib re-export
0e297dc to
ba90324
Compare
Contributor
Author
It's re-exporting the |
nekevss
approved these changes
Sep 25, 2025
Member
nekevss
left a comment
There was a problem hiding this comment.
just needs a cargo fmt and it should be good to go
ba90324 to
170f828
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Temporal::nowa typeNow<DefaultHostSystem>is returned. However, theDefaultHostSystemis not accessible from the outside, making it impossible to use it as a type.I've also re-exported the
EmptyHostSystem, where I'm not 100% sure if it should be, but I believe it is correct to do so.