Skip to content

Add TryFrom for PartialDuration to Duration#585

Merged
Manishearth merged 2 commits intomainfrom
add-duration-try-from
Sep 22, 2025
Merged

Add TryFrom for PartialDuration to Duration#585
Manishearth merged 2 commits intomainfrom
add-duration-try-from

Conversation

@nekevss
Copy link
Copy Markdown
Member

@nekevss nekevss commented Sep 21, 2025

This PR adds a TryFrom implemenation for converting a PartialDuration to Duration.

The core reasoning is to simplify the case where someone would want to add a single day in Rust.

use temporal_rs::{Temporal, PlainDate, partial::PartialDuration};

let today = Temporal::now().plain_date_iso(None).unwrap();
let one_day = PartialDuration::empty().with_days(1);
// Before: 
// let tomorrow = today.add(Duration::from_partial_duration(one_day).unwrap()).unwrap()
// After:
let tomorrow = today.add(one_day.try_into().unwrap()).unwrap();

@nekevss nekevss requested a review from Manishearth September 21, 2025 23:24
@Manishearth Manishearth merged commit c909108 into main Sep 22, 2025
8 checks passed
@Manishearth Manishearth deleted the add-duration-try-from branch September 22, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants