Update to ICU4X's new Calendar::from_fields#582
Merged
Manishearth merged 10 commits intoboa-dev:mainfrom Sep 26, 2025
Merged
Conversation
089f553 to
1fff416
Compare
Contributor
Author
|
Test failure is unicode-org/icu4x#6966 |
931fb9e to
0982363
Compare
75a28ee to
46660f2
Compare
Contributor
Author
|
Should not be merged until after 0.1.0 |
71d56b8 to
22db47b
Compare
Contributor
Author
|
This passes built-ins/Temporal/ and intl402/Temporal with icu_calendar at 73723dc8973974b0c156dd04e807c3eadaf4cd5c and temporal_rs at 63fe650, with additional new passing tests and no new failing tests. So there is no regression with this. Some tests I expected to get fixed have not yet been fixed. |
Contributor
Author
|
I think with unicode-org/icu4x#6969 all the tests that I expect to pass now pass. Remaining failures are due to arithmetic or a couple other minor known issues (like the duration float rounding issue) |
63fe650 to
dc6b2ff
Compare
dc6b2ff to
d7c8cba
Compare
nekevss
approved these changes
Sep 26, 2025
Member
nekevss
left a comment
There was a problem hiding this comment.
Looks good! Actually glad to see a good path forward for the era data and resolution logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes most of the ResolveCalendarFields code. I kept some around as ResolvedIsoFields since the ISO code is separately specced and we should not rely on ICU4X for that.