Skip to content

Handle und month codes#563

Merged
Manishearth merged 2 commits intoboa-dev:mainfrom
Manishearth:month-code-und
Sep 13, 2025
Merged

Handle und month codes#563
Manishearth merged 2 commits intoboa-dev:mainfrom
Manishearth:month-code-und

Conversation

@Manishearth
Copy link
Copy Markdown
Contributor

We hit debug assertions here.

@sffc Should ICU4X be producing these at all? I think perhaps we should only ever produce valid month codes, producing M00/M13 when out of range.

@Manishearth Manishearth requested a review from nekevss September 12, 2025 20:14
@sffc
Copy link
Copy Markdown
Contributor

sffc commented Sep 12, 2025

Once we adopt Pinqi then this should be a moot point

@Manishearth
Copy link
Copy Markdown
Contributor Author

@sffc This was happening in Hijri

const v2 = Temporal.PlainMonthDay;
const v7 = {
    calendar: "islamic-umalqura",
    day: 18,
    era: "bh",
    eraYear: 65536,
    monthCode: "M12",
};
v2.from(v7);

@Manishearth
Copy link
Copy Markdown
Contributor Author

Yes, this will be a moot point, but we should perhaps do something less unexpected for 2.1.

@Manishearth Manishearth merged commit 93f8ac6 into boa-dev:main Sep 13, 2025
8 checks passed
@Manishearth Manishearth deleted the month-code-und branch September 13, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants