Skip to content

Review and update PlainDate and PlainDateTime API#561

Merged
nekevss merged 4 commits intomainfrom
api-audit-2
Sep 12, 2025
Merged

Review and update PlainDate and PlainDateTime API#561
nekevss merged 4 commits intomainfrom
api-audit-2

Conversation

@nekevss
Copy link
Copy Markdown
Member

@nekevss nekevss commented Sep 12, 2025

This PR reviews and makes updates to the API of PlainDate and PlainDateTime.

There are a variety of changes made:

  • with_calendar methods made infallible
  • PDT::to_plain_date and PDT::to_plain_time made infallible.
  • Updates function signatures for TimeZone to not take a reference (in temporal_rs public API only, omitted from temporal_capi).
  • Documentations updates.
  • module renames from date.rs and datetime.rs to plain_date.rs and plain_date_time.rs, respectively.

@nekevss nekevss requested a review from Manishearth September 12, 2025 05:29
@nekevss nekevss added the C-api Changes related to the public API label Sep 12, 2025
@nekevss nekevss merged commit f9b84f7 into main Sep 12, 2025
8 checks passed
@nekevss nekevss deleted the api-audit-2 branch September 14, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-api Changes related to the public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants