Refactor Now to be trait based for lazy host getters#560
Merged
Conversation
Manishearth
approved these changes
Sep 12, 2025
Contributor
Manishearth
left a comment
There was a problem hiding this comment.
Design looks good overall. I don't use any of this in V8, I just implement it from scratch (it's not much).
|
|
||
| // Implement empty providers | ||
|
|
||
| impl HostClock for () { |
Contributor
There was a problem hiding this comment.
nit: I'd make an EmptyProvider type that documents its behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #547
This basically removes the NowBuilder approach for a trait based approach.
In order to do this, it adds the HostClock, HostTimeZone, and HostHooks traits. I could see adding the HostHooks trait as potentially superfluous / controversial with the other two traits already present, but I thought it may provide a bit cleaner interface. Let me know what you think. Definitely willing to work shop this one a bit more if need be.
I did test this in Boa locally and there shouldn't be any regressions, which is nice.