Add provider APIs to capi#544
Merged
Manishearth merged 8 commits intoboa-dev:mainfrom Sep 10, 2025
Merged
Conversation
3c0208e to
53771e0
Compare
53771e0 to
d4d0641
Compare
d4d0641 to
da576fe
Compare
Contributor
Author
|
cc @linusg who may care about using custom timezone data |
3621815 to
8b54868
Compare
8b54868 to
b5ce341
Compare
linusg
approved these changes
Sep 9, 2025
Contributor
linusg
left a comment
There was a problem hiding this comment.
For the time being I'm planning to stick with the compiled providers (same for icu4x) but this LGTM :)
nekevss
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The general design: all compiled_data methods get with_provider versions; the compiled_data call is tweaked to use a compiled provider. In theory I could choose to not proxy compiled_data methods to with_provider ones but it's cleaner this way, and as long as the build configuration doesn't enable two backends it should be zero-cost.
Haven't done everything yet, but this is the approach.